Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): stably print lists in front of whitespace-only trailing newline #5024

Merged

Conversation

ikatyang
Copy link
Member

@ikatyang ikatyang commented Aug 29, 2018

Fixes #5021

Prettier pr-5024
Playground link

--parser babylon

Input:

if (true) {
  md`
text1
- 123
  - 456

text2
- 123
  - 456

text3
- 123
  - 456
`;
}

Output:

if (true) {
  md`
text1

- 123
  - 456

text2

- 123
  - 456

text3

- 123
  - 456
  `;
}
  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang merged commit 669282e into prettier:master Sep 1, 2018
@ikatyang ikatyang deleted the fix/markdown/falso-positive-for-list-loose branch September 1, 2018 04:14
@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Jan 23, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants