Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): do not add whitespaces between Latin and Hangul #5040

Merged
merged 9 commits into from Sep 2, 2018

Conversation

Projects
None yet
3 participants
@ikatyang
Copy link
Member

commented Sep 1, 2018

Fixes #5028

Based on #5028 (comment), it seems Korean text uses conventional space so we're not going to add whitespaces between Latin and Hangul.


Prettier pr-5040
Playground link

--parser markdown

Input:

안녕하세요. 저는 Prettier을 굉장히 잘 사용하고 있습니다.
그런데 Prettier는 영어와 한글 사이에 무조건 빈 공간을 입력하고 있어요.
... ㅠㅠ

Output:

안녕하세요. 저는 Prettier을 굉장히 잘 사용하고 있습니다.
그런데 Prettier는 영어와 한글 사이에 무조건 빈 공간을 입력하고 있어요.
... ㅠㅠ

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
}

const json = JSON.stringify(
require(id.replace(/^\0commonjs-proxy:/, "")),

This comment has been minimized.

Copy link
@suchipi

suchipi Sep 1, 2018

Member

Where does this \0commonjs-proxy: come from?

This comment has been minimized.

Copy link
@ikatyang

ikatyang Sep 1, 2018

Author Member

rollup-plugin-commonjs I guess?

This comment has been minimized.

Copy link
@suchipi

suchipi Sep 1, 2018

Member

Ah okay, I was just confused

@suchipi

suchipi approved these changes Sep 1, 2018

@@ -1,6 +1,6 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`cjk.md - markdown-verify 1`] = `
exports[`cj.md - markdown-verify 1`] = `

This comment has been minimized.

Copy link
@j-f1

j-f1 Sep 1, 2018

Member

What do you think about renaming these to chinese-japanese.md and korean.md so it’s clearer at first glance what they’re testing?

Or are cj and k common abbreviations?

This comment has been minimized.

Copy link
@suchipi

suchipi Sep 1, 2018

Member

I've seen CJK, but never CJ and K as separate abbreviations

@ikatyang ikatyang merged commit 9120689 into prettier:master Sep 2, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.53% (+<.01%) compared to db2bc36
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/markdown/korean-whitespace branch Sep 2, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.