New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): add parens for complex nodes in ClassExpression #5074

Merged
merged 2 commits into from Sep 10, 2018

Conversation

Projects
None yet
2 participants
@ikatyang
Member

ikatyang commented Sep 9, 2018

Fixes #5073


Prettier pr-5074
Playground link

--parser typescript

Input:

let Subclass2 = class extends (Superclass as AssertedSuperclass) {};

Output:

let Subclass2 = class extends (Superclass as AssertedSuperclass) {};

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@j-f1

j-f1 approved these changes Sep 9, 2018

@j-f1 j-f1 changed the title from fix(typescript): add parens for TSAsExpression in ClassExpression to fix(typescript): add parens for complex nodes in ClassExpression Sep 9, 2018

@ikatyang ikatyang merged commit 9ca10a3 into prettier:master Sep 10, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 8283320...1277f65
Details
codecov/project 96.25% remains the same compared to 8283320
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/typescript/parens-for-as-in-class-expr branch Sep 10, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment