New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep simple JSXOpeningTag's unbroken #5078

Merged
merged 1 commit into from Sep 11, 2018

Conversation

Projects
None yet
4 participants
@duailibe
Member

duailibe commented Sep 10, 2018

Closes #5075

The bug happens because single line template literals don't break and we inline template literals if they're the only children of a JSX tag because of #1090. The simplest fix is to prevent simple <Tag> from breaking.

@existentialism

👍

@duailibe duailibe merged commit b020a56 into prettier:master Sep 11, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.25% (+0%) compared to 9ca10a3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@duailibe duailibe deleted the duailibe:unbreak-jsx-open-tag branch Sep 11, 2018

@vramana

This comment has been minimized.

Collaborator

vramana commented Sep 11, 2018

@duailibe Thanks a lot.

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment