New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): no invalid parens for destructuring with default value #5096

Merged
merged 1 commit into from Sep 15, 2018

Conversation

Projects
None yet
5 participants
@ikatyang
Member

ikatyang commented Sep 14, 2018

Fixes #4813


Prettier pr-5096
Playground link

--parser typescript

Input:

let toAssign: string;
({ prop: toAssign = "default" } = { prop: "propval" });

Output:

let toAssign: string;
({ prop: toAssign = "default" } = { prop: "propval" });

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@ikatyang ikatyang merged commit 5cd367e into prettier:master Sep 15, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.27% (+<.01%) compared to 8b0bdf5
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/typescript/no-invalid-parens branch Sep 15, 2018

@maxlang

This comment has been minimized.

maxlang commented Sep 16, 2018

Thanks!

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment