New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(markdown): trailing spaces after front matters are allowed #5107

Merged
merged 2 commits into from Sep 21, 2018

Conversation

Projects
None yet
5 participants
@ikatyang
Member

ikatyang commented Sep 19, 2018

Fixes #5106

---···· <--- allowed
yaml
---···· <--- allowed

markdown

Prettier pr-5107
Playground link

--parser markdown

Input:

---
Title: Title
--- 

|                         |                                                 |                             |
| ----------------------- | ----------------------------------------------- | --------------------------- |
| Laufzeit                | (laufen + Zeit) Period of Validity              | Prepaid ohne Laufzeit       |
| Aufladezwangen          | (Aufladen + Zwang) Charding Obligation          | Prepaid ohne Aufladezwang   |
| Zeitbegrenzung          | (Zeit + begrenzung) Time Limit                  | Prepaid ohne Zeitbegrenzung |
| Deaktivierungszeiträume | (Deaktivierung + Zeiträume)Deactivation Periods |                             |
| Ablaufdatum             | Expiration Date                                 |                             |
| verfallen               | To expire                                       |                             |
| Aktivitätszeitfensters  | Activity time windows                           |                             |

---

Output:

---
Title: Title
---

|                         |                                                 |                             |
| ----------------------- | ----------------------------------------------- | --------------------------- |
| Laufzeit                | (laufen + Zeit) Period of Validity              | Prepaid ohne Laufzeit       |
| Aufladezwangen          | (Aufladen + Zwang) Charding Obligation          | Prepaid ohne Aufladezwang   |
| Zeitbegrenzung          | (Zeit + begrenzung) Time Limit                  | Prepaid ohne Zeitbegrenzung |
| Deaktivierungszeiträume | (Deaktivierung + Zeiträume)Deactivation Periods |                             |
| Ablaufdatum             | Expiration Date                                 |                             |
| verfallen               | To expire                                       |                             |
| Aktivitätszeitfensters  | Activity time windows                           |                             |

---

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@j-f1

This comment has been minimized.

Member

j-f1 commented Sep 19, 2018

How do you feel about retitling this “fix(markdown): trim trailing spaces in front matter delimiters”?

@ikatyang

This comment has been minimized.

Member

ikatyang commented Sep 19, 2018

🤔 We actually just add the ability to parse the front matter that has trailing spaces, the trimming is more like a side effect.

@ikatyang ikatyang merged commit 0cbacd3 into prettier:master Sep 21, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.24% (+0%) compared to 79f4251
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/markdown/front-matter-trailing-spaces branch Sep 21, 2018

@m1ck2

This comment has been minimized.

m1ck2 commented Sep 21, 2018

Can you just explain what is needed please

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment