Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js) Break args when second arg is a ternary (#5046) #5151

Merged
merged 1 commit into from Sep 27, 2018

Conversation

Projects
None yet
4 participants
@onurtemizkan
Copy link
Contributor

commented Sep 27, 2018

Fixes: #5046

To prevent ugly output when the first argument is a [Function|ArrowFunction]Expression and the second is a ConditionalExpression, arguments are broken.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@evilebottnawi
Copy link
Member

left a comment

Good job!

@j-f1

j-f1 approved these changes Sep 27, 2018

Copy link
Member

left a comment

Nice!

@j-f1 j-f1 merged commit d7e96ad into prettier:master Sep 27, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 07abf05...2a4ecd0
Details
codecov/project 96.31% remains the same compared to 07abf05
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.