Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript) Do not add extra semicolon to `TSMethodSignature` when `prettier-ignore` is used (#5140) #5160

Merged

Conversation

Projects
None yet
3 participants
@onurtemizkan
Copy link
Contributor

commented Sep 29, 2018

Fixes: #5140

Separator paths are shifted for TSMethodSignatures when prettier-ignore is used, just as TSPropertySignatures.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@onurtemizkan onurtemizkan changed the title fix(typescript) Do not add extra semicolon to `TSMethodSignature` when `prettier-ingore` is used (#5140) fix(typescript) Do not add extra semicolon to `TSMethodSignature` when `prettier-ignore` is used (#5140) Sep 29, 2018

@onurtemizkan onurtemizkan force-pushed the onurtemizkan:fix/ts/ignore-method-signature-semi branch from 58c9a42 to c4bb11e Sep 29, 2018

@j-f1

j-f1 approved these changes Sep 29, 2018

Copy link
Member

left a comment

Thanks for contributing!

@j-f1 j-f1 merged commit cc83a27 into prettier:master Sep 29, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 87e109f...c4bb11e
Details
codecov/project 96.31% remains the same compared to 87e109f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.