New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct parentheses for mixed exp/mod #5243

Merged
merged 1 commit into from Oct 12, 2018

Conversation

Projects
None yet
6 participants
@bakkot
Collaborator

bakkot commented Oct 10, 2018

Fixes #5238.

cc @duailibe for the original change. I basically undid that PR because it didn't look to me like shouldFlatten made sense as the place to introduce the behavior it was going for, but I might have misunderstood something.

@duailibe

This comment has been minimized.

Member

duailibe commented Oct 10, 2018

Yeah I can't remember the details, but thanks for that

@j-f1 j-f1 merged commit cbcd24a into prettier:master Oct 12, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +3.78% compared to ed6a2d9
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@bakkot bakkot deleted the bakkot:fix-exp-mod branch Oct 12, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment