Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unstable comment between function declaration and block statement #5250

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Projects
None yet
3 participants
@jaideng123
Copy link
Contributor

commented Oct 11, 2018

Fixes #5241

Fixed the Issues with unstable comments between function declaration and block statements described in #5241 by adding a clause that checks if a comment is enclosed by a function declaration and followed by a block statement it will move the comment inside the block statement as the first line.
This is the same way comments are handled in if statements before a block statement.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@lipis

lipis approved these changes Nov 1, 2018

@lipis

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

Shall we take this in?

@evilebottnawi

This comment has been minimized.

Copy link
Member

commented Nov 1, 2018

I think it is ready to merge

@lipis lipis merged commit 0799280 into prettier:master Nov 1, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.21% (+<.01%) compared to 3056c5a
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@lipis lipis added this to the 1.15 milestone Nov 1, 2018

@lipis lipis referenced this pull request Nov 1, 2018

Merged

docs(blog): 1.15 release #5296

@lock lock bot locked as resolved and limited conversation to collaborators Jan 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.