New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed unstable while comment #5251

merged 3 commits into from Oct 25, 2018


None yet
4 participants

jaideng123 commented Oct 12, 2018

Fixed an Issues with unstable comments inside a while condition (described in #5245 ) by adding a handler function that applies only while loops that checks if a comment is before the end of the condition then maintains the trailing comment after the Boolean expression
I also made the formatting of comments on while loops more similar to if statements as referenced in the Issue thread

Fixes #5245.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

jaideng123 added some commits Oct 12, 2018


j-f1 approved these changes Oct 13, 2018


lydell approved these changes Oct 25, 2018

@j-f1 j-f1 merged commit 2cc32da into prettier:master Oct 25, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
ci/circleci: checkout_code Your tests passed on CircleCI!
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
codecov/patch 100% of diff hit (target 80%)
codecov/project 96.22% (+<.01%) compared to 3369be0
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
deploy/netlify Deploy preview ready!

This comment has been minimized.


j-f1 commented Oct 25, 2018

Thanks for contributing!

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

ikatyang added a commit to ikatyang/prettier that referenced this pull request Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment