New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break nested TSConditionalType #5272

Merged
merged 1 commit into from Oct 15, 2018

Conversation

Projects
None yet
2 participants
@duailibe
Member

duailibe commented Oct 15, 2018

Fixes #5267

@duailibe duailibe requested a review from ikatyang Oct 15, 2018

@@ -3277,7 +3277,7 @@ function printPathNoParens(path, options, print, args) {
consequentNodePropertyName: "trueType",
alternateNodePropertyName: "falseType",
testNodePropertyName: "checkType",
breakNested: false
breakNested: true

This comment has been minimized.

@duailibe

duailibe Oct 15, 2018

Member

FTR this is true in both calls of this function now

@duailibe duailibe merged commit 00004da into prettier:master Oct 15, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 0fa34b2...d296e36
Details
codecov/project 96.38% remains the same compared to 0fa34b2
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@duailibe duailibe deleted the duailibe:break-ts-conditional branch Oct 15, 2018

@ikatyang ikatyang added this to the 1.15 milestone Oct 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment