Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flow parser to 0.84.0 #5303

Merged
merged 1 commit into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@jbrown215
Copy link
Contributor

commented Oct 25, 2018

Fixes #5084

Update the flow parser to 0.84.0, which includes parser support for explicit inexact objects using .... See https://medium.com/flow-type/on-the-roadmap-exact-objects-by-default-16b72933c5cf for more info.

One test had to be re-recorded

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

@jbrown215 jbrown215 referenced this pull request Oct 25, 2018

Merged

Pretty print inexact #5304

2 of 2 tasks complete
@lydell
Copy link
Collaborator

left a comment

I'm so excited for the upcoming exact-by-default Flow versions now! 🎉

This looks good to me. Just have a minor question about the changed snapshot.

@lydell lydell added this to the 1.15 milestone Oct 26, 2018

@ikatyang ikatyang merged commit 5d47e02 into prettier:master Oct 26, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 1234ceb...f0b9ecb
Details
codecov/project 96.4% remains the same compared to 1234ceb
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
@ikatyang

This comment has been minimized.

Copy link
Member

commented Oct 26, 2018

Thanks!

ikatyang added a commit to ikatyang/prettier that referenced this pull request Oct 26, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.