New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never put spaces to the right of stars in indentable block comments #5330

Merged
merged 2 commits into from Nov 3, 2018

Conversation

Projects
None yet
3 participants
@lydell
Collaborator

lydell commented Nov 3, 2018

Fixes #5323. Previously we added space after /* on the first line
only,
but the intent is to only fix the indentation of comments, not
changing their "contents". Besides, this was inconsistent with the
handling of every following line. Finally, it broke /*! comments which
some minifiers look for to know which (license) comments to keep.

People can use https://eslint.org/docs/rules/spaced-comment to enforce
when to start comments with spaces.

@j-f1 Does this feel like the right approach to you?

Never put spaces to the right of stars in indentable block comments
Fixes #5323. Previously we added space after `/*` _on the first line
only,_ but the intent is to only fix the indentation of comments, not
changing their "contents". Besides, this was inconsistent with the
handling of every following line. Finally, it broke `/*!` comments which
some minifiers look for to know which (license) comments to keep.

People can use https://eslint.org/docs/rules/spaced-comment to enforce
when to start comments with spaces.

@lydell lydell requested a review from j-f1 Nov 3, 2018

@j-f1

j-f1 approved these changes Nov 3, 2018

LGTM

@lydell lydell merged commit 275b054 into prettier:master Nov 3, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.41% (+0%) compared to f6d8be8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@lydell lydell deleted the lydell:comment-space branch Nov 3, 2018

@ikatyang ikatyang added this to the 1.15 milestone Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment