New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(less): remove CRs from inline comments #5334

Merged
merged 1 commit into from Nov 4, 2018

Conversation

Projects
None yet
2 participants
@ikatyang
Member

ikatyang commented Nov 3, 2018

Fixes #5315

The issue is that less parser somehow included CRs in comment.raws.content, but it was hidden by the wrong trailing space elimination previously, which was fixed by #5165.

  • I’ve added tests to confirm my change works.
    We already have such tests but it's not reproducible in AppVeyor since they use LF (core.autocrlf=input).
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.
@lydell

lydell approved these changes Nov 3, 2018

@ikatyang ikatyang added this to the 1.15 milestone Nov 4, 2018

@ikatyang ikatyang merged commit 0878a6a into prettier:master Nov 4, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 96.41% (+0%) compared to f6d8be8
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/less/crlf-inline-comment branch Nov 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment