Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): preserve content for `<template>` with unknown lang #5388

Merged
merged 5 commits into from Nov 9, 2018

Conversation

Projects
None yet
4 participants
@ikatyang
Copy link
Member

ikatyang commented Nov 8, 2018

Fixes #5371

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 8, 2018

@lydell

lydell approved these changes Nov 8, 2018

@ikatyang ikatyang changed the title fix(html): ignore `<template>` with unknown lang fix(html): preserve content for `<template>` with unknown lang Nov 9, 2018

@ikatyang ikatyang merged commit 6f6b634 into prettier:master Nov 9, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.03% (+<.01%) compared to 12a8fa3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/html/ignore-unknown-template-lang branch Nov 9, 2018

@Aysnine Aysnine referenced this pull request Nov 11, 2018

Closed

Lint pug template #640

@lock lock bot locked as resolved and limited conversation to collaborators Feb 7, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.