Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): inline property decorator should stay inline (part 2) #5423

Merged
merged 6 commits into from Nov 10, 2018

Conversation

@ikatyang
Copy link
Member

commented Nov 9, 2018

Fixes cases mentioned in #5360 (comment)

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang changed the title fix(javascript): inline property decorator should stay inline (part 2) fix(javascript): inline decorator should stay inline Nov 9, 2018

@@ -99,24 +99,6 @@ class HeroButtonComponent {
}
```

There's one exception: classes. We don't think it ever makes sense to inline the decorators for them, so they are always moved to their own line.

This comment has been minimized.

Copy link
@ikatyang

@ikatyang ikatyang requested a review from lydell Nov 9, 2018

@duailibe
Copy link
Member

left a comment

I agree with the property changes, but the classes I don't think we should change 🤷‍♂️

It was one person who "complained" and also noted the mobx docs have example of both kinds, but I'm not willing do die on any particular hill these days, so you all are free to decide which is best.

@ikatyang

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2018

OK, let's bisect them from this PR and see how people think about it.

ikatyang added 2 commits Nov 9, 2018
Revert "test: add tests"
This reverts commit 6c0d6d6.

@ikatyang ikatyang changed the title fix(javascript): inline decorator should stay inline fix(javascript): inline property decorator should stay inline (part 2) Nov 9, 2018

@lydell
lydell approved these changes Nov 9, 2018

@ikatyang ikatyang merged commit 8b1260a into prettier:master Nov 10, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.03% (+<.01%) compared to 12a8fa3
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/javascript/inline-decorator branch Nov 10, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.