Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle reselect's createSelector as function composition #5430

Merged
merged 1 commit into from Nov 10, 2018

Conversation

@ThiefMaster
Copy link
Contributor

commented Nov 9, 2018

This fixes #5285; initially I thought this was a feature but after seeing that #4431 already added special handling for similar function composition functions, including one from redux, I think adding support for reselect's createSelector could be considered a fix (especially since it's an official library in the same github org as redux)

Try the playground for this PR

@ThiefMaster

This comment has been minimized.

Copy link
Contributor Author

commented Nov 9, 2018

CI failures seem unrelated

@suchipi

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

Looks great, thank you!

@suchipi suchipi merged commit 6dcc7ed into prettier:master Nov 10, 2018

3 of 8 checks passed

ci/circleci: test_prod_node4 Your tests failed on CircleCI
Details
ci/circleci: test_prod_node9 Your tests failed on CircleCI
Details
ci/circleci: test_prod_standalone Your tests failed on CircleCI
Details
continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 10, 2018

@ThiefMaster ThiefMaster deleted the ThiefMaster:create-selector branch Nov 10, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.