Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): fix locEnd for VariableDeclaration caused by --no-semi #5434

Merged
merged 2 commits into from Nov 10, 2018

Conversation

@ikatyang
Copy link
Member

commented Nov 10, 2018

Fixes #5409

There should be a lot of places could be fixed by this kind of method but I just want to fix the regression one for now.

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.15.2 milestone Nov 10, 2018

@j-f1

This comment has been minimized.

Copy link
Member

commented Nov 10, 2018

Ooh, could this finally fix #1510?

@ikatyang

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2018

Probably, but we need to fix it case-by-case.

@lipis
lipis approved these changes Nov 10, 2018

@ikatyang ikatyang merged commit 7e72889 into prettier:master Nov 10, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.03% (+0.01%) compared to d4c248b
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/javascript/no-semi-comment branch Nov 10, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Feb 8, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.