Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): tweak semicolon for single expression in event bindings #5519

Merged
merged 6 commits into from Nov 29, 2018

Conversation

@ikatyang
Copy link
Member

commented Nov 21, 2018

Fixes #5509
Fixes #5510

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 23, 2018

@ikatyang

This comment has been minimized.

Copy link
Member Author

commented Nov 27, 2018

(I'll merge this PR tomorrow if there's no further comment.)

@ikatyang ikatyang merged commit 0534735 into prettier:master Nov 29, 2018

11 of 14 checks passed

codecov/project 97.03% (-0.04%) compared to 4af3dd4
Details
Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 90% of diff hit (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20181125.11 succeeded
Details

@ikatyang ikatyang deleted the ikatyang:fix/vue/event-binding-semi branch Nov 29, 2018

tigefa4u pushed a commit to tigefa4u/gitlabhq that referenced this pull request Jan 14, 2019
Upgrade prettier and reformat files as necessary
Upgrades prettier to 1.15.3
Runs `yarn prettier-save-all` against the codebase
Most changes are due to prettier/prettier#5519

@lock lock bot locked as resolved and limited conversation to collaborators Feb 27, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.