Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue,ng): do not normalize tag names #5526

Merged
merged 4 commits into from Nov 23, 2018

Conversation

@ikatyang
Copy link
Member

commented Nov 22, 2018

Fixes #5524

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@j-f1
j-f1 approved these changes Nov 22, 2018
Copy link
Member

left a comment

Does the Angular need to be updated?

@lipis
lipis approved these changes Nov 22, 2018

@ikatyang ikatyang changed the title fix(vue): do not normalize tag names fix(vue,ng): do not normalize tag names Nov 22, 2018

@lipis

This comment has been minimized.

Copy link
Member

commented Nov 22, 2018

We should make a release after all these little fixes..

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 23, 2018

@ikatyang ikatyang merged commit cdac955 into prettier:master Nov 23, 2018

10 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.08% (+0%) compared to 6ee2f46
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20181122.8 succeeded
Details

@ikatyang ikatyang deleted the ikatyang:fix/vue/do-not-normalize-tag-name branch Nov 23, 2018

colebemis added a commit to CSC307Fall2018/team-too that referenced this pull request Nov 27, 2018
Remove prettier from precommit hook
Will add back when this PR gets released: prettier/prettier#5526

@lock lock bot locked as resolved and limited conversation to collaborators Feb 21, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.