Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): add missing parens for binary in optionalMember #5543

Conversation

@ikatyang
Copy link
Member

commented Nov 24, 2018

Fixes #5535

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@j-f1
j-f1 approved these changes Nov 24, 2018
Copy link
Member

left a comment

(off-topic) @ikatyang do you have access to the Prettier site on Netlify? If so, could I have access?

ikatyang added 4 commits Nov 25, 2018
@ikatyang

This comment has been minimized.

Copy link
Member Author

commented Nov 25, 2018

I've changed Netlify to use the GitHub App instead of webhooks but it seems it's still not accessible for people with write access. I guess we're probably under a personal plan but we could change it to use a free open source plan with team support. (I cannot access the plan info so I'm not sure.)

cc @azz

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 25, 2018

@ikatyang ikatyang merged commit c788842 into prettier:master Nov 25, 2018

12 of 14 checks passed

Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing a50a8e2...5c57954
Details
codecov/project 97.05% remains the same compared to a50a8e2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20181125.4 succeeded
Details

@ikatyang ikatyang deleted the ikatyang:fix/javascript/parens-for-binary-in-optional-member branch Nov 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Feb 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.