Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html-in-js): do not add quotes for interpolation-only attributes #5544

Conversation

@ikatyang
Copy link
Member

commented Nov 24, 2018

Fixes #5538

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@lipis
lipis approved these changes Nov 24, 2018
@j-f1
j-f1 approved these changes Nov 24, 2018
Copy link
Member

left a comment

Still works for html`<div foo="${bar}">` .

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 25, 2018

@ikatyang ikatyang merged commit b6a04ab into prettier:master Nov 25, 2018

8 checks passed

ci/circleci: build_prod Your tests passed on CircleCI!
Details
ci/circleci: checkout_code Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node4 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_node9 Your tests passed on CircleCI!
Details
ci/circleci: test_prod_standalone Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20181124.4 succeeded
Details

@ikatyang ikatyang deleted the ikatyang:fix/html-in-js/do-not-add-quotes-for-interpolation-only-attr branch Nov 25, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Feb 23, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.