Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): do not change `module` into `namespace` and break/hug their body correctly #5551

Merged
merged 3 commits into from Nov 26, 2018

Conversation

@ikatyang
Copy link
Member

commented Nov 25, 2018

Fixes #5533

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 25, 2018

@j-f1
j-f1 approved these changes Nov 25, 2018

@ikatyang ikatyang merged commit 3a5bbf5 into prettier:master Nov 26, 2018

8 of 10 checks passed

Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +2.92% compared to 4af3dd4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20181125.16 succeeded
Details
prod Workflow: prod
Details

@ikatyang ikatyang deleted the ikatyang:fix/typescript/module-namespace branch Nov 26, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Feb 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.