Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): support interpolation in attributes #5573

Merged
merged 5 commits into from Nov 30, 2018

Conversation

@ikatyang
Copy link
Member

commented Nov 28, 2018

Fixes #5477

(Vue: "Interpolation inside attributes has been removed. Use v-bind or the colon shorthand instead.")

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.15.3 milestone Nov 28, 2018

@ikatyang

This comment has been minimized.

Copy link
Member Author

commented Nov 28, 2018

(This one should be the last PR in 1.15.3.)

@ikatyang ikatyang merged commit 2247ce1 into prettier:master Nov 30, 2018

8 of 10 checks passed

Header rules No header rules processed
Details
Pages changed 2 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 97.04% (+<.01%) compared to 3fcf69a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20181129.7 succeeded
Details
prod Workflow: prod
Details

@ikatyang ikatyang deleted the ikatyang:feat/angular/intepolation-in-attr branch Nov 30, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Feb 28, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant
You can’t perform that action at this time.