Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript): stable parens for function type in arrow return type #5790

Conversation

@ikatyang
Copy link
Member

commented Jan 22, 2019

Fixes #5789

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang added this to the 1.16.1 milestone Jan 22, 2019

@VincentLanglet
Copy link

left a comment

I tested
const foo = (): (() => void) => (): void => null;
const bar = (): () => void => (): void => null;
const baz = (): ((() => void)) => (): void => null;

And
class Foo {
foo: (() => void)
}

In the playground, and it works well

@j-f1
j-f1 approved these changes Jan 22, 2019

@ikatyang ikatyang merged commit 153d2d0 into prettier:master Jan 22, 2019

6 of 8 checks passed

Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 94.39% (+<.01%) compared to 1061be0
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20190122.9 succeeded
Details

@ikatyang ikatyang deleted the ikatyang:fix/typescript/parens-for-function-type-in-arrow-return-type branch Jan 22, 2019

@automatops automatops referenced this pull request Jan 22, 2019
0 of 1 task complete
@ibf-renovate ibf-renovate referenced this pull request Jan 22, 2019
0 of 1 task complete

@lock lock bot locked as resolved and limited conversation to collaborators Apr 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.