Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(html): do not format non-normal whitespaces as normal whitespaces #5797

Merged

Conversation

@ikatyang
Copy link
Member

commented Jan 24, 2019

Fixes #5796

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@ikatyang ikatyang requested a review from prettier/core Jan 28, 2019

@ikatyang ikatyang added this to the 1.16.2 milestone Jan 28, 2019

@lydell

This comment has been minimized.

Copy link
Collaborator

commented Jan 28, 2019

Looks good to me. Does the HTML spec say anything about this?

@lipis
lipis approved these changes Jan 28, 2019

@ikatyang ikatyang merged commit 847a78e into prettier:master Jan 30, 2019

5 of 8 checks passed

prettier.prettier Build #20190130.3 has failed
Details
Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
codecov/patch Coverage not affected when comparing 1802ce1...406715a
Details
codecov/project 94.4% remains the same compared to 1802ce1
Details
deploy/netlify Deploy preview ready!
Details

@ikatyang ikatyang deleted the ikatyang:fix/html/non-breaking-narrow-whitespace branch Jan 30, 2019

@automatops automatops referenced this pull request Jan 30, 2019
0 of 1 task complete
@ibf-renovate ibf-renovate referenced this pull request Jan 30, 2019
0 of 1 task complete

@lock lock bot locked as resolved and limited conversation to collaborators Apr 30, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.