Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup getSupportInfo for babylon parser prior to 1.16.0 #5826

Merged
merged 4 commits into from Feb 3, 2019

Conversation

@azz
Copy link
Member

commented Feb 3, 2019

This undoes an accidental breaking change where prettier.getSupportInfo('1.0.0') would report supporting the babel parser instead of babylon.

Fixes #5822

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If not an internal change) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.
azz added 3 commits Feb 3, 2019
\\"flow\\",
],
\\"Less\\": Array [
\\"less\\",
],
+ \\"Lightning Web Components\\": Array [

This comment has been minimized.

Copy link
@azz

azz Feb 3, 2019

Author Member

I assume this is correct as it is unreleased?

@azz azz merged commit 2982dcd into prettier:master Feb 3, 2019

16 of 18 checks passed

Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 3 redirect rules processed
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 94.4% (+<.01%) compared to a093bb3
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20190203.5 succeeded
Details
prettier.prettier (Dev Lint on Linux Node v10) Dev Lint on Linux Node v10 succeeded
Details
prettier.prettier (Dev Test on Linux Node v10) Dev Test on Linux Node v10 succeeded
Details
prettier.prettier (Dev Test on Windows Node v10) Dev Test on Windows Node v10 succeeded
Details
prettier.prettier (Dev Test on macOS Node v10) Dev Test on macOS Node v10 succeeded
Details
prettier.prettier (Prod Build on Linux Node v10) Prod Build on Linux Node v10 succeeded
Details
prettier.prettier (Prod Lint on Linux Node v10) Prod Lint on Linux Node v10 succeeded
Details
prettier.prettier (Prod Pack on Linux Node v10) Prod Pack on Linux Node v10 succeeded
Details
prettier.prettier (Prod Test on macOS Node_v10) Prod Test on macOS Node_v10 succeeded
Details
prettier.prettier (Prod Test on macOS Node_v10_standalone) Prod Test on macOS Node_v10_standalone succeeded
Details
prettier.prettier (Prod Test on macOS Node_v4) Prod Test on macOS Node_v4 succeeded
Details

@azz azz deleted the azz:support-info-babel branch Feb 3, 2019

@azz

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2019

Any idea why I'm getting build failure emails from CircleCI? Is Circle even in use anymore?

image

@ikatyang

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Circle was removed in #5611, but it seems we forgot to remove their webhooks.

EDIT: I've disabled them.

@azz

This comment has been minimized.

Copy link
Member Author

commented Feb 3, 2019

Thanks! Azure pipelines look pretty neat. Are there any issues I should read through to catch up on current state of CI?

@ikatyang

This comment has been minimized.

Copy link
Member

commented Feb 3, 2019

Azure Pipelines was introduced in #5410 and then tweaked in #5611/#5498, these 3 PRs should include everything about our current CI state. Basically, it's just migrated from Circle/Travis to Azure Pipelines with the same test steps, the docs for Azure Pipelines could be found here.

ikatyang added a commit that referenced this pull request Feb 3, 2019
Fixup getSupportInfo for babylon parser prior to 1.16.0 (#5826)
This undoes an accidental breaking change where `prettier.getSupportInfo('1.0.0')` would report supporting the `babel` parser instead of `babylon`.

Fixes #5822

@ikatyang ikatyang added this to the 1.16.4 milestone Feb 3, 2019

@automatops automatops referenced this pull request Feb 3, 2019
0 of 1 task complete
@ibf-renovate ibf-renovate referenced this pull request Feb 3, 2019
0 of 1 task complete

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.