Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same print width for range formatting as normal formatting. #6050

Merged
merged 2 commits into from May 4, 2019

Conversation

@mathieulj
Copy link
Contributor

commented Apr 11, 2019

Fixes an issue were a file would end up formatted differently with ranged formatting (--range-start & --range-end) versus normal whole file formatting.

Fixes #6046

  • I’ve added tests to confirm my change works.
  • (n/a) (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@j-f1
j-f1 approved these changes Apr 12, 2019
mathieulj added 2 commits Apr 11, 2019
Fixes an issue were a file would end up formatted differently
with ranged formatting (--range-start & --range-end) versus
normal whole file formatting.
@mathieulj mathieulj force-pushed the mathieulj:master branch from e2a7472 to 02a3895 May 4, 2019
@mathieulj

This comment has been minimized.

Copy link
Contributor Author

commented May 4, 2019

Rebased on top of upstream master to resolve conflicts.

@j-f1 j-f1 merged commit 26183e5 into prettier:master May 4, 2019
16 of 18 checks passed
16 of 18 checks passed
Header rules No header rules processed
Details
Pages changed 1 new file uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 4 redirect rules processed
Details
codecov/patch Coverage not affected when comparing 84cc273...02a3895
Details
codecov/project 94.27% remains the same compared to 84cc273
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20190504.1 succeeded
Details
prettier.prettier (Dev Lint on Linux Node v10) Dev Lint on Linux Node v10 succeeded
Details
prettier.prettier (Dev Test on Linux Node v10) Dev Test on Linux Node v10 succeeded
Details
prettier.prettier (Dev Test on Windows Node v10) Dev Test on Windows Node v10 succeeded
Details
prettier.prettier (Dev Test on macOS Node v10) Dev Test on macOS Node v10 succeeded
Details
prettier.prettier (Prod Build on Linux Node v10) Prod Build on Linux Node v10 succeeded
Details
prettier.prettier (Prod Lint on Linux Node v10) Prod Lint on Linux Node v10 succeeded
Details
prettier.prettier (Prod Pack on Linux Node v10) Prod Pack on Linux Node v10 succeeded
Details
prettier.prettier (Prod Test on macOS Node_v10) Prod Test on macOS Node_v10 succeeded
Details
prettier.prettier (Prod Test on macOS Node_v10_standalone) Prod Test on macOS Node_v10_standalone succeeded
Details
prettier.prettier (Prod Test on macOS Node_v4) Prod Test on macOS Node_v4 succeeded
Details
@j-f1

This comment has been minimized.

Copy link
Member

commented May 4, 2019

Thank you for contributing!

@automatops automatops referenced this pull request May 13, 2019
0 of 1 task complete
This was referenced Jun 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.