Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved multiline closure comment detection #6070

Merged
merged 2 commits into from May 7, 2019

Conversation

@yangsu
Copy link
Contributor

commented Apr 18, 2019

Fixes #6067

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@evilebottnawi

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Something wrong with CI

@j-f1

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Restarted the CI.

@j-f1
j-f1 approved these changes Apr 20, 2019
@j-f1

This comment has been minimized.

Copy link
Member

commented Apr 20, 2019

Looks like the changelog didn’t get updated. Can you add an entry for this change?

@yangsu

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

oops. will do

Fixes #6067
@yangsu yangsu force-pushed the quip:fix-closure-comment branch from 9a22ed2 to 4a67b6f May 4, 2019
@duailibe duailibe merged commit 54b7655 into prettier:master May 7, 2019
16 of 18 checks passed
16 of 18 checks passed
Header rules No header rules processed
Details
Pages changed All files already uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 4 redirect rules processed
Details
codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 94.27% (+<.01%) compared to 26183e5
Details
deploy/netlify Deploy preview ready!
Details
prettier.prettier Build #20190505.1 succeeded
Details
prettier.prettier (Dev Lint on Linux Node v10) Dev Lint on Linux Node v10 succeeded
Details
prettier.prettier (Dev Test on Linux Node v10) Dev Test on Linux Node v10 succeeded
Details
prettier.prettier (Dev Test on Windows Node v10) Dev Test on Windows Node v10 succeeded
Details
prettier.prettier (Dev Test on macOS Node v10) Dev Test on macOS Node v10 succeeded
Details
prettier.prettier (Prod Build on Linux Node v10) Prod Build on Linux Node v10 succeeded
Details
prettier.prettier (Prod Lint on Linux Node v10) Prod Lint on Linux Node v10 succeeded
Details
prettier.prettier (Prod Pack on Linux Node v10) Prod Pack on Linux Node v10 succeeded
Details
prettier.prettier (Prod Test on macOS Node_v10) Prod Test on macOS Node_v10 succeeded
Details
prettier.prettier (Prod Test on macOS Node_v10_standalone) Prod Test on macOS Node_v10_standalone succeeded
Details
prettier.prettier (Prod Test on macOS Node_v4) Prod Test on macOS Node_v4 succeeded
Details
@duailibe

This comment has been minimized.

Copy link
Member

commented May 7, 2019

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.