JavaScript: Support Smart and F#-style Pipeline by sosukesuzuki · Pull Request #6319 · prettier/prettier

sosukesuzuki · 2019-07-20T08:54:01Z

Support Smart Pipeline and F#-style Pipeline.

More about those proposals ("What's Happening With the Pipeline (|>) Proposal?").

Smart Pipeline:

// Input
5 |> # * 2

// Output (Prettier Stable)
SyntaxError: Unexpected character '#' (1:6)
> 1 | 5 |> # * 2
    |      ^

// Output (Prettier master)
5 |> # * 2

F#-style Pipeline:

// Input
promises |> await;

// Output
SyntaxError: Unexpected token (1:18)
> 1 | promises |> await
    |                  ^

// Output (Prettier master)
promises |> await;

ref: #7953

I’ve added tests to confirm my change works.
(If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
(If the change is user-facing) I’ve added my changes to the CHANGELOG.unreleased.md file following the template.
I’ve read the contributing guidelines.

✨Try the playground for this PR✨

duailibe · 2019-07-22T13:47:23Z

+        [
+          "decorators-legacy",
+          ["pipelineOperator", { proposal: "minimal" }]
+        ].concat(extraPlugins)


This is bad. I added that as an escape-hatch until I could figure out a decent way to detect which decorator plugin to apply.

This will likely cause a noticeable performance degradation, specially when there's a simple syntax error.

@sosukesuzuki Why not always use proposal: 'smart'?

The smart is compatible with minimal, but it is coincidental. For example, the same problem will occur again when we try to support fsarp.

So, I considered generally solution...

As far as I understand, we'll need to check only smart and fsharp then. Why check minimal?

smart is not compatible w/ minimal, so that's not a safe assumption. x |> foo() is invalid in smart but valid in minimal.

Oh, I see now. That's really unlucky. Hopefully Babel's error recovery might help here.

If it doesn't help, I'm going to make Prettier try using each proposal until the input parses. To avoid overhead, this logic will be used only if the input contains the substring |>.

alexander-akait · 2019-10-01T17:20:23Z

In theory we can use babel api to detect plugin, if no plugins found use minimal

thorn0 · 2019-10-01T18:49:23Z

Or we can suppress reparsing attempts if the file doesn't contain the substring |>.

duailibe · 2019-10-03T14:42:26Z

@thorn0 That would be ideal

mAAdhaTTah · 2019-10-24T19:08:33Z

I helped implement the Smart & F# proposals in Babel. Is there anything I can do to help this land?

thorn0 · 2020-02-24T21:25:40Z

@mAAdhaTTah Is there a quick and dirty way (like a regex) to detect which proposal was used in given code without full parsing?

mAAdhaTTah · 2020-02-24T21:36:14Z

@thorn0 Not that I can think of. Does prettier read the Babel config? That's probably the most reliable source of which pipeline operator is in use.

thorn0 · 2020-02-24T21:42:35Z

That's the problem, it doesn't read it. And we'd like to avoid that as Prettier's configuration story is already complicated enough.

mAAdhaTTah · 2020-02-24T22:37:46Z

@thorn0 How was this resolved for decorators? Similar approach, or was there something about the various decorator proposals that make this not an issue?

thorn0 · 2020-02-24T22:41:21Z

@mAAdhaTTah The error recovery works really beautifully for decorators. Previously, we had to iterate through different option combinations to find the working one, but now (since v1.19) Prettier even supports different decorator variants within one file.

mAAdhaTTah · 2020-02-24T22:42:42Z

@thorn0 Cool alright, if there's anything I can do to adjust the error handling in Babel, let me know, but it might works as-is for this.

thorn0 · 2020-02-24T22:57:05Z

foo |> bar() works (playground), even though proposal is set to smart.

But it doesn't recover from f# proposal syntax:

foo |> await |> bar (playground, await could be parsed as identifier in the error recovery mode)
foo |> bar => bar (playground)
something else?

thorn0 · 2020-02-28T17:41:08Z

@mAAdhaTTah Could you make those errors recoverable, please?

mAAdhaTTah · 2020-02-28T19:44:38Z

@thorn0 I will look into that!

sosukesuzuki · 2020-04-05T11:05:13Z

CI is failing due to memory problem, I may need to increase max-old-space-size or reduce maxWorker of Jest.
Please let me know if there is a better solution.

thorn0 · 2020-04-05T12:48:24Z

The memory problem happens because resolvePluginsConflict repeatedly modifies the same array, so it becomes huge.

thorn0

Looks good. Could you add more code to the tests? E.g. from articles like this one.

thorn0 · 2020-04-07T20:31:41Z

+                node.body.operator === "|>")
+            );
+          }
+          return false;


This leads to a bug:

Prettier pr-6319
Playground link

--parser typescript

Input:

((x) => x) + '';

Output:

(x) => x + "";

thorn0 · 2020-04-07T20:38:16Z

+      }
+    }
+  }
+  return combinations;


Let's say the input combinations are [["jsx", "typescript"], ["typescript"]], in that case the output will be:

[ ["jsx", "typescript"], ["typescript"], ["jsx", "typescript", ["pipelineOperator", { proposal: "smart" }]], ... ]

Why do we need the first two elements in this list?

kachkaev · 2020-08-24T17:44:01Z

Hey folks sorry for a late comment here. Just a question on:

- [Link to the 'smart' pipeline proposal](https://github.com/js-choi/proposal-smart-pipelines)

Any reason to link to the fork (67 stars) instead of https://github.com/tc39/proposal-pipeline-operator (4.8K stars)? If no specific reasons, WDYT of changing the link in the 2.1 blog post while it's fresh?

thorn0 · 2020-08-24T19:13:08Z

@kachkaev There are three different pipeline operator proposals: "minimal" (the one you linked to), "f#", and "smart".

duailibe reviewed Jul 22, 2019

View reviewed changes

fisker reviewed Oct 1, 2019

View reviewed changes

Comment thread CHANGELOG.unreleased.md Outdated

thorn0 changed the base branch from master to next February 24, 2020 21:52

thorn0 force-pushed the smart-pipeline branch from 468bc38 to 5c58564 Compare February 24, 2020 22:04

thorn0 force-pushed the smart-pipeline branch from 8dd1f7b to 83157be Compare February 24, 2020 23:07

thorn0 force-pushed the next branch from 55247de to 262423a Compare March 21, 2020 19:03

thorn0 changed the base branch from next to master March 21, 2020 21:01

thorn0 force-pushed the master branch from 0be5680 to e23e5cc Compare March 22, 2020 01:49

sosukesuzuki mentioned this pull request Apr 4, 2020

JavaScript: Avoid Babel's proposal conflicts #7953

Closed

2 of 3 tasks

sosukesuzuki and others added 6 commits April 5, 2020 17:28

Modify to support smart-pipeline in printer

4082f5e

Add tests

4930602

add a changelog entry

b543ada

change minimal to smart

2c3dc3a

fix parens issues

429aae1

Support fsharp-pipeline

e3269f0

sosukesuzuki force-pushed the smart-pipeline branch from 2b3105e to e3269f0 Compare April 5, 2020 09:52

thorn0 reviewed Apr 5, 2020

View reviewed changes

Comment thread src/language-js/needs-parens.js Outdated

Fix needs-parens

e59a1dd

thorn0 added this to the 2.1 milestone Apr 5, 2020

sosukesuzuki changed the title ~~JavaScript: Support Smart Pipeline~~ JavaScript: Support Smart and F#-style Pipeline Apr 5, 2020

Try to fix ci problem

f6aab2c

sosukesuzuki force-pushed the smart-pipeline branch from 635b4d4 to f6aab2c Compare April 5, 2020 19:19

Update changelog

41ff833

sosukesuzuki force-pushed the smart-pipeline branch from cc3762c to 41ff833 Compare April 5, 2020 19:55

sosukesuzuki requested a review from thorn0 April 5, 2020 21:33

thorn0 approved these changes Apr 6, 2020

View reviewed changes

Add more tests

4193463

sosukesuzuki force-pushed the smart-pipeline branch from 021097b to 4193463 Compare April 7, 2020 06:26

alexander-akait approved these changes Apr 7, 2020

View reviewed changes

sosukesuzuki merged commit ccaaad0 into prettier:master Apr 7, 2020

sosukesuzuki deleted the smart-pipeline branch April 7, 2020 10:42

thorn0 reviewed Apr 7, 2020

View reviewed changes

sosukesuzuki mentioned this pull request Apr 7, 2020

JavaScript: Fix pipeline bugs #7979

Merged

3 tasks done

This comment has been minimized.

Sign in to view

github-actions Bot locked as resolved and limited conversation to collaborators Aug 25, 2021

Conversation

sosukesuzuki commented Jul 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

duailibe Jul 22, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

thorn0 Jul 24, 2019

Choose a reason for hiding this comment

Uh oh!

sosukesuzuki Jul 25, 2019

Choose a reason for hiding this comment

Uh oh!

thorn0 Oct 1, 2019

Choose a reason for hiding this comment

Uh oh!

mAAdhaTTah Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

thorn0 Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alexander-akait commented Oct 1, 2019

Uh oh!

thorn0 commented Oct 1, 2019

Uh oh!

duailibe commented Oct 3, 2019

Uh oh!

mAAdhaTTah commented Oct 24, 2019

Uh oh!

thorn0 commented Feb 24, 2020

Uh oh!

mAAdhaTTah commented Feb 24, 2020

Uh oh!

thorn0 commented Feb 24, 2020

Uh oh!

mAAdhaTTah commented Feb 24, 2020

Uh oh!

thorn0 commented Feb 24, 2020

Uh oh!

mAAdhaTTah commented Feb 24, 2020

Uh oh!

thorn0 commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thorn0 commented Feb 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mAAdhaTTah commented Feb 28, 2020

Uh oh!

Uh oh!

sosukesuzuki commented Apr 5, 2020

Uh oh!

thorn0 commented Apr 5, 2020

Uh oh!

thorn0 left a comment

Choose a reason for hiding this comment

Uh oh!

thorn0 Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

thorn0 Apr 7, 2020

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

kachkaev commented Aug 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thorn0 commented Aug 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sosukesuzuki commented Jul 20, 2019 •

edited

Loading

duailibe Jul 22, 2019 •

edited

Loading

thorn0 commented Feb 24, 2020 •

edited

Loading

thorn0 commented Feb 28, 2020 •

edited

Loading

kachkaev commented Aug 24, 2020 •

edited

Loading