Add breakParent support for willBreak #674

Merged
merged 2 commits into from Mar 17, 2017

Conversation

Projects
None yet
2 participants
@vjeux
Collaborator

vjeux commented Feb 12, 2017

Fixes #615

@@ -20,17 +20,16 @@ export default function searchUsers(action$) {
.ofType(ActionTypes.SEARCHED_USERS)
.map(action => action.payload.query)
.filter(q => !!q)
- .switchMap(q =>

This comment has been minimized.

@jlongster

jlongster Feb 13, 2017

Member

Is this right? This looks like a regression that we fixed before

@jlongster

jlongster Feb 13, 2017

Member

Is this right? This looks like a regression that we fixed before

This comment has been minimized.

@vjeux

vjeux Feb 13, 2017

Collaborator

I don't know what it should look like. Right now it alternates depending on the context. See #625 for another example.

@vjeux

vjeux Feb 13, 2017

Collaborator

I don't know what it should look like. Right now it alternates depending on the context. See #625 for another example.

@jlongster

This comment has been minimized.

Show comment
Hide comment
@jlongster

jlongster Feb 14, 2017

Member

Hm, interesting, I think this is right actually. I wasn't sure about it at first because this will find any breakParent even though it won't be propagated through conditionalGroups, but I suppose that happens with all other things that will propagate breaks anyway. I'd still like take a closer look before merging to think about it

Member

jlongster commented Feb 14, 2017

Hm, interesting, I think this is right actually. I wasn't sure about it at first because this will find any breakParent even though it won't be propagated through conditionalGroups, but I suppose that happens with all other things that will propagate breaks anyway. I'd still like take a closer look before merging to think about it

@vjeux

This comment has been minimized.

Show comment
Hide comment
@vjeux

vjeux Mar 7, 2017

Collaborator

I'd love to get this committed as it sounds reasonable and fixes a bunch of the unstable issues we have on fb codebase.

Collaborator

vjeux commented Mar 7, 2017

I'd love to get this committed as it sounds reasonable and fixes a bunch of the unstable issues we have on fb codebase.

@jlongster

This comment has been minimized.

Show comment
Hide comment
@jlongster

jlongster Mar 17, 2017

Member

Just rebased this and I'll merge it once green. I'm not sure what to think of thinks like conditionalGroup because we'll return true if a hard line or breakParent exists anywhere in there even though it might not be printed. We haven't run into an issue with that yet.

Member

jlongster commented Mar 17, 2017

Just rebased this and I'll merge it once green. I'm not sure what to think of thinks like conditionalGroup because we'll return true if a hard line or breakParent exists anywhere in there even though it might not be printed. We haven't run into an issue with that yet.

@vjeux

This comment has been minimized.

Show comment
Hide comment
@vjeux

vjeux Mar 17, 2017

Collaborator

(You need to re-record the snapshot tests)

Collaborator

vjeux commented Mar 17, 2017

(You need to re-record the snapshot tests)

@jlongster jlongster merged commit 3554799 into prettier:master Mar 17, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment