Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handlebars: Add prettier-ignore #7275

Merged
merged 5 commits into from Jan 20, 2020
Merged

Conversation

chadian
Copy link
Contributor

@chadian chadian commented Jan 11, 2020

This pull request adds the ability to use {{! prettier-ignore }} in glimmer/handlebars

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@chadian chadian force-pushed the hbs-prettier-ignore branch 3 times, most recently from 2ef2818 to f4bcf7f Compare Jan 11, 2020
@chadian chadian force-pushed the hbs-prettier-ignore branch 2 times, most recently from 481b926 to b8e594f Compare Jan 13, 2020
@chadian chadian requested review from alexander-akait and lipis Jan 14, 2020
lipis
lipis approved these changes Jan 14, 2020
@lipis
Copy link
Member

lipis commented Jan 14, 2020

Maybe updating the docs to reflect this change?

@chadian
Copy link
Contributor Author

chadian commented Jan 15, 2020

@lipis That sounds like a good idea. Can you point me in the right direction of which docs to update?

@lipis
Copy link
Member

lipis commented Jan 15, 2020

https://github.com/prettier/prettier/blob/master/docs/ignore.md

@chadian chadian changed the title Glimmer: Add prettier-ignore handlebars: Add prettier-ignore Jan 16, 2020
@chadian
Copy link
Contributor Author

chadian commented Jan 18, 2020

@lipis Thanks! I've included an example in the ignore docs.

thorn0
thorn0 approved these changes Jan 18, 2020
@lipis
Copy link
Member

lipis commented Jan 19, 2020

Linter is complaining.

@thorn0 thorn0 closed this Jan 20, 2020
@thorn0 thorn0 reopened this Jan 20, 2020
@chadian
Copy link
Contributor Author

chadian commented Jan 20, 2020

Thanks @thorn0!

@lipis lipis merged commit aa24837 into prettier:master Jan 20, 2020
18 checks passed
@chadian chadian deleted the hbs-prettier-ignore branch Jan 20, 2020
@lock lock bot added the locked-due-to-inactivity label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
locked-due-to-inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants