Skip to content

handlebars: Add prettier-ignore #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 20, 2020
Merged

handlebars: Add prettier-ignore #7275

merged 5 commits into from
Jan 20, 2020

Conversation

chadian
Copy link
Contributor

@chadian chadian commented Jan 11, 2020 •
edited
Loading

This pull request adds the ability to use {{! prettier-ignore }} in glimmer/handlebars

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@chadian chadian force-pushed the hbs-prettier-ignore branch 3 times, most recently from 2ef2818 to f4bcf7f Compare January 11, 2020 21:05
@chadian chadian mentioned this pull request Jan 11, 2020
Closed
@chadian chadian force-pushed the hbs-prettier-ignore branch 2 times, most recently from 481b926 to b8e594f Compare January 13, 2020 14:32
@chadian chadian force-pushed the hbs-prettier-ignore branch from b8e594f to 0ab2b2e Compare January 13, 2020 14:32
@lipis
Copy link
Member

lipis commented Jan 14, 2020

Maybe updating the docs to reflect this change?

@chadian
Copy link
Contributor Author

chadian commented Jan 15, 2020

@lipis That sounds like a good idea. Can you point me in the right direction of which docs to update?

@lipis
Copy link
Member

lipis commented Jan 15, 2020

https://github.com/prettier/prettier/blob/master/docs/ignore.md

@chadian chadian changed the title Glimmer: Add prettier-ignore handlebars: Add prettier-ignore Jan 16, 2020
@chadian
Copy link
Contributor Author

chadian commented Jan 18, 2020

@lipis Thanks! I've included an example in the ignore docs.

@lipis
Copy link
Member

lipis commented Jan 19, 2020

Linter is complaining.

@thorn0 thorn0 closed this Jan 20, 2020
@thorn0 thorn0 reopened this Jan 20, 2020
@thorn0 thorn0 force-pushed the hbs-prettier-ignore branch from 9d3e19e to 00a2139 Compare January 20, 2020 00:12
@chadian
Copy link
Contributor Author

chadian commented Jan 20, 2020

Thanks @thorn0!

@lipis lipis merged commit aa24837 into prettier:master Jan 20, 2020
@chadian chadian deleted the hbs-prettier-ignore branch January 20, 2020 18:10
@lock lock bot added the locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting. label Apr 25, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Apr 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@thorn0 thorn0 thorn0 approved these changes

@lipis lipis lipis approved these changes

@alexander-akait alexander-akait Awaiting requested review from alexander-akait

Assignees
No one assigned
Labels
locked-due-to-inactivity Please open a new issue and fill out the template instead of commenting.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadian @lipis @thorn0