Skip to content

JavaScript: Support Babel 7.10 private field in in#8431

Merged
sosukesuzuki merged 3 commits into
prettier:masterfrom
sosukesuzuki:support-babel-private-in
May 27, 2020
Merged

JavaScript: Support Babel 7.10 private field in in#8431
sosukesuzuki merged 3 commits into
prettier:masterfrom
sosukesuzuki:support-babel-private-in

Conversation

@sosukesuzuki
Copy link
Copy Markdown
Contributor

@sosukesuzuki sosukesuzuki commented May 27, 2020

  • I’ve added tests to confirm my change works.
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

Copy link
Copy Markdown
Member

@fisker fisker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WTF? Private field can use outside a class?

@sosukesuzuki sosukesuzuki merged commit f31430d into prettier:master May 27, 2020
@sosukesuzuki sosukesuzuki deleted the support-babel-private-in branch May 27, 2020 18:02
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants