Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Babel: support record and tuple syntax #8453

Merged
merged 4 commits into from Jun 3, 2020
Merged

Babel: support record and tuple syntax #8453

merged 4 commits into from Jun 3, 2020

Conversation

fisker
Copy link
Sponsor Member

@fisker fisker commented May 29, 2020

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker fisker marked this pull request as ready for review May 29, 2020 03:14
alexander-akait
alexander-akait reviewed May 29, 2020
View reviewed changes
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stage 1, I think we should resolve #8448 before merge this stuff

@fisker
Copy link
Sponsor Member Author

fisker commented May 29, 2020 •
edited

#8448 is only about docs, we even support stage-0 features, like pipeline.

@fisker fisker merged commit 2b68f98 into prettier:master Jun 3, 2020
@fisker fisker deleted the support-record-and-tuple branch June 3, 2020 01:35
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexander-akait alexander-akait alexander-akait approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fisker @alexander-akait @sosukesuzuki