New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support babel-ts
AST type TSNamedTupleMember
#8885
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge after first merge
@@ -0,0 +1,22 @@ | |||
// https://github.com/babel/babel/pull/11754 | |||
// TODO: move this file to `test/typescript/tuple` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current typescript-estree cannot parse labeled tuple types. So we should put this in /tests/misc/typescript-babel-only
for now.
Sorry in advance if this is the wrong place, but Prettier still doesn't seem to be able to handle labelled tuple types. I'm trying to use Prettier v2.3.0 from within VS Code and it's not working. I'm using Parcel Bundler for my project. What do I need to do to get it to handle this syntax correctly? |
Hi @thorn0, thanks for looking into this. I managed to reproduce this on a CodeSandbox. You can invoke Prettier by saving the file. Let me know if you need anything else from me. |
Sorry, but this isn't a valid isolated reproduce. If you can't provide a reproduce that doesn't involve third-party things like VS Code or CodeSandbox, that means that the problem is not on Prettier's side. Prettier formats that code with no problem: playground |
Fixes #8883
Include changes from #8869, should merge it first.
docs/
directory)changelog_unreleased/*/pr-XXXX.md
file followingchangelog_unreleased/TEMPLATE.md
.✨Try the playground for this PR✨