New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 2.1 blog post #8932

Merged

sosukesuzuki merged 25 commits into prettier:master from sosukesuzuki:2.1-blog-post

Aug 24, 2020

Member

sosukesuzuki commented Aug 7, 2020 •

edited

There's still todo for 2.1 milestone, but I create PR for a quick review and release. This PR is still draft but reviews welcome! I'm not good at English, so it would be helpful if you could review English.

TODO

Update contents when we've completed 2.1 milestone.
- ~~If Avoid line-breaking inside a method chain before breaking the chain itself #8063 is completed, I'll add it to Highlights~~
Remove all pr-xxxx.md from /changelog_unreleased
Rewrite // Prettier stable => // Prettier 2.0, // Prettier master -> // Prettier 2.1
- write a script on other PR (Add script to replace Prettier stable/Prettier master with the actual versions #8984)
Update filename

https://deploy-preview-8932--prettier.netlify.app/blog/2020/08/24/2.1.0.html


          Add draft for 2.1 blog post

12f0eb4

sosukesuzuki added this to the 2.1 milestone

sosukesuzuki commented

View reviewed changes

website/blog/2020-08-04-2.1.0.md Outdated

Comment on lines 122 to 144

+              #### Further improve method chain breaking heuristic ([#7889](https://github.com/prettier/prettier/pull/7889) by [@thorn0](https://github.com/thorn0))
+              A method chain now is always split onto multiple lines if:
+              - it's an expression statement and all its arguments are literals or `UPPERCASE_CONSTANT`s (the "fluent configuration" pattern),
+              - any call but the first one has more than two arguments, or
+              - the chain starts with a constructor call.
+              <!-- prettier-ignore -->
+              ```jsx
+              // Input
+              cy.get(".ready")
+                .should("have.text", "FOO")
+                .should("have.css", "color", "#aaa");
+              // Prettier stable
+              cy.get(".ready").should("have.text", "FOO").should("have.css", "color", "#aaa");
+              // Prettier master
+              cy.get(".ready")
+                .should("have.text", "FOO")
+                .should("have.css", "color", "#aaa");
+              ```

This comment was marked as resolved.

Sign in to view


          Update cspell.json

e832661

sosukesuzuki mentioned this pull request

Release 2.1 checklist #8882

Closed

10 tasks

fisker reviewed

View reviewed changes

cspell.json Outdated Show resolved Hide resolved

Sponsor Member

fisker commented Aug 9, 2020 •

edited

#8410 codeblock not right
#7592 #7844 codeblock not highlighted

#7844 Should move to scss/

brodybits reviewed

View reviewed changes

website/blog/2020-08-04-2.1.0.md Outdated Show resolved Hide resolved

brodybits reviewed

View reviewed changes

Contributor

brodybits left a comment

I just left some changes, suggestions, and questions so far.

I will try to review the rest of the post today.

In general, I wonder if we should state which parsers the new ES proposals are supported on.

website/blog/2020-08-04-2.1.0.md Outdated Show resolved Hide resolved

website/blog/2020-08-04-2.1.0.md Outdated Show resolved Hide resolved

website/blog/2020-08-04-2.1.0.md Outdated


		### JavaScript

		#### Support the F# and Smart pipeline operator proposals ([#6319](https://github.com/prettier/prettier/pull/6319) by [@sosukesuzuki](https://github.com/sosukesuzuki), [@thorn0](https://github.com/thorn0), [#7979](https://github.com/prettier/prettier/pull/7979) by [@sosukesuzuki](https://github.com/sosukesuzuki))

Contributor

brodybits Aug 9, 2020

Should we tell which parsers this would be supported by?

I think they would be babel, babel-flow, and babel-ts.

Member Author

sosukesuzuki Aug 9, 2020 •

edited

Yes, the feature works on only babel

website/blog/2020-08-04-2.1.0.md Outdated Show resolved Hide resolved

website/blog/2020-08-04-2.1.0.md Outdated Show resolved Hide resolved

website/blog/2020-08-04-2.1.0.md Outdated

+              }
+              ```
+              #### Support Private Fields in `in` ([#8431](https://github.com/prettier/prettier/pull/8431) by [@sosukesuzuki](https://github.com/sosukesuzuki))

Contributor

brodybits Aug 9, 2020

only on Babel parsers, right?

(I did just raise PR #8942 to run the test on all Babel parsers.)

Member Author

sosukesuzuki Aug 9, 2020

Yes, works on only babel

sosukesuzuki and others added 8 commits

August 15, 2020 17:30


          Update website/blog/2020-08-04-2.1.0.md

fd5c224

Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>


          Update website/blog/2020-08-04-2.1.0.md

25053ce

Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>


          Update website/blog/2020-08-04-2.1.0.md

685a238

Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>


          Update website/blog/2020-08-04-2.1.0.md

2204a59

Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>


          Update website/blog/2020-08-04-2.1.0.md

Co-authored-by: Chris Brody <chris.brody+brodybits@gmail.com>


          Merge branch 'master' into 2.1-blog-post

0581ddc


          Update changelogs

f5a30b4


          Add author to cspell ignore patterns

36cce5c

fisker reviewed

View reviewed changes

cspell.json Outdated Show resolved Hide resolved


          Update cspell.json

d202490

fisker reviewed

View reviewed changes

website/blog/2020-08-04-2.1.0.md Outdated Show resolved Hide resolved

sosukesuzuki added 5 commits

August 15, 2020 21:47


          Fix original changelog

d629579


          Merge branch 'master' into 2.1-blog-post

8946c4b


          Run draft script

16a04f3


          Update


          Fix TypeScript on Highlights

9b5d9ed

sosukesuzuki commented

View reviewed changes

website/blog/2020-08-21-2.1.0.md Outdated

               ```
-              #### Support `Labeled Tuple Elements` ([#8885](https://github.com/prettier/prettier/pull/8885) by [@fisker](https://github.com/fisker), [#8982](https://github.com/prettier/prettier/pull/8982) by [@sosukesuzuki](https://github.com/sosukesuzuki))
+              #### Short-Circuiting Assignment Operators ([#8982](https://github.com/prettier/prettier/pull/8982) by [@sosukesuzuki](https://github.com/sosukesuzuki))

Member Author

sosukesuzuki Aug 21, 2020

I added about Short-Circuiting Assignment Operators here #8982 (comment)

sosukesuzuki added 2 commits

August 21, 2020 17:00


          Fix heading

877c7bc


          Fix author

ee2c08d

Sponsor Member

fisker commented Aug 21, 2020

@sosukesuzuki #8932 (comment)


          Fix changelog for 8410

c28670c

sosukesuzuki added 2 commits

August 21, 2020 18:48


          Fix syntax highlight

3c99549


          Move changelog for 7844 to /scss

f3997da

ExE-Boss reviewed

View reviewed changes

website/blog/2020-08-21-2.1.0.md Outdated Show resolved Hide resolved

sosukesuzuki marked this pull request as ready for review

August 21, 2020 11:18


          Update website/blog/2020-08-21-2.1.0.md

b670a42

Co-authored-by: ExE Boss <3889017+ExE-Boss@users.noreply.github.com>

sosukesuzuki requested review from fisker and alexander-akait

August 22, 2020 02:47

fisker approved these changes

View reviewed changes

alexander-akait approved these changes

View reviewed changes

Member

alexander-akait left a comment

Let's do it ⭐

Sponsor Member

fisker commented Aug 22, 2020

Do you guys have npm publish permission?

Member

alexander-akait commented Aug 22, 2020

@vjeux friendly ping

Contributor

vjeux commented Aug 22, 2020

@evilebottnawi what do you need from me?

Member Author

sosukesuzuki commented Aug 23, 2020

@vjeux Can you give me a npm publish permission for Prettier? https://www.npmjs.com/~sosukesuzuki

Contributor

vjeux commented Aug 23, 2020

I have issues connecting to my account right now. @j-f1, @duailibe, @suchipi could one of you help? Thanks!

Member

thorn0 commented Aug 23, 2020

@sosukesuzuki I added you.

sosukesuzuki added 2 commits

August 24, 2020 16:03


          Remove changelog_unreleased

fd4da0b


          Update filename

dc7b708

Member Author

sosukesuzuki commented Aug 24, 2020

@thorn0 @fisker Should we merge this before running release script?

Sponsor Member

fisker commented Aug 24, 2020

I don't know, but according to #8882, merge after release.

Sponsor Member

fisker commented Aug 24, 2020

So the script you wrote to replace prettier version won't work? You can replace it manually, let's improve it later.

Member Author

sosukesuzuki commented Aug 24, 2020

Yes, I was worried about that too. In this release I'll replace it manually.


          Replace to actual version manually

sosukesuzuki merged commit 18b4cab into prettier:master

sosukesuzuki deleted the 2.1-blog-post branch

August 24, 2020 11:36

AlCalzone commented Aug 24, 2020

Maybe I'm blind, but whats the difference under "Fix unstable comments in binary expressions"?

// Prettier 2.0 (first output)
Math.min(
  /* foo */
  document.body.scrollHeight -
    (window.scrollY + window.innerHeight) -
    devsite_footer_height,
  0
);

// Prettier 2.0 (second output)
Math.min(
  /* foo */
  document.body.scrollHeight -
    (window.scrollY + window.innerHeight) -
    devsite_footer_height,
  0
);

looks identical to me.

Sponsor Member

fisker commented Aug 24, 2020 •

edited

@AlCalzone Thank you, I've fixed it 2fe0415

Math.min(
  /* foo */
  document.body.scrollHeight -
-  (window.scrollY + window.innerHeight) -
+    (window.scrollY + window.innerHeight) -
    devsite_footer_height,
  0
);

Contributor

vjeux commented Aug 24, 2020

Congratz everyone on the release!

sosukesuzuki mentioned this pull request

Replace changelog versions in ./scripts/draft-blog-post.js #9058

Merged

1 task

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.