Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Continuation of revert 7889 #9024

Merged
merged 4 commits into from Aug 22, 2020
Merged

Continuation of revert 7889 #9024

merged 4 commits into from Aug 22, 2020

Conversation

sosukesuzuki
Copy link
Member

When I run Prettier on other project (vue-eslint-plugin), I found a my mistake on #8861. (ref: https://github.com/sosukesuzuki/eslint-plugin-vue/pull/1/files#diff-059836f827f3d7b6a3f91b4cf782717bR10-R14)

  • I’ve added tests to confirm my change works.
  • (If changing the API or CLI) I’ve documented the changes I’ve made (in the docs/ directory)
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/pr-XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

✨Try the playground for this PR✨

@fisker
Copy link
Member

fisker commented Aug 22, 2020

I'll double check within 1h

@fisker
Copy link
Member

fisker commented Aug 22, 2020 •
edited

isLiteralLikeValue function not reverted, and not used.

@fisker
Copy link
Member

fisker commented Aug 22, 2020

callHasComplexArguments is not the same as before.

@fisker
Copy link
Member

fisker commented Aug 22, 2020

This part seem not same as before too https://github.com/prettier/prettier/pull/7889/files#diff-7b1bcccb83db0724493babfb845acdfdR359

@sosukesuzuki
Copy link
Member Author

@fisker Thank you for your double check. I fixed.

fisker
fisker approved these changes Aug 22, 2020
View reviewed changes
Copy link
Member

@fisker fisker left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm the new test changes are the same as before, I'm offline.

@sosukesuzuki sosukesuzuki merged commit c4e9dd9 into prettier:master Aug 22, 2020
@sosukesuzuki sosukesuzuki deleted the continu-revert-7889 branch August 22, 2020 16:23
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fisker fisker fisker approved these changes

@alexander-akait alexander-akait alexander-akait approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sosukesuzuki @fisker @alexander-akait