Replace changelog versions in ./scripts/draft-blog-post.js #9058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fisker
reviewed
Aug 25, 2020
scripts/draft-blog-post.js
Outdated
|
|
||
| const changelogUnreleasedDir = path.join(__dirname, "../changelog_unreleased"); | ||
| const blogDir = path.join(__dirname, "../website/blog"); | ||
| const introFile = path.join(changelogUnreleasedDir, "blog-post-intro.md"); | ||
| const version = require("../package.json").version.replace(/-.+/, ""); | ||
| const previousVersion = execSync("git describe --tags --abbrev=0") |
There was a problem hiding this comment.
how about require('prettier/package.json').version
fisker
approved these changes
Aug 25, 2020
alexander-akait
approved these changes
Aug 25, 2020
fisker
reviewed
Aug 25, 2020
| @@ -80,22 +82,24 @@ rimraf.sync(postGlob); | |||
|
|
|||
| fs.writeFileSync( | |||
There was a problem hiding this comment.
Should we run prettier.format on this file?
There was a problem hiding this comment.
This file is created when repo linting with stable, and merge when master already released and updated, so there is a chance this file will fail on lint?
There was a problem hiding this comment.
There may be a chance. But we use this script when before release. So I'm not sure if the problem is fixed with using prettier.format on this script.
There was a problem hiding this comment.
If we use stable prettier format it, it will fail after merge.
If we use master prettier format it, it will fail when sending PR.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
#8932 (comment)