Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix formatting for AssignmentExpression with ClassExpression #9741

Merged
merged 5 commits into from Nov 22, 2020

Conversation

sosukesuzuki
Copy link
Member

@sosukesuzuki sosukesuzuki commented Nov 21, 2020

Description

Fixes #9740

Checklist

  • I’ve added tests to confirm my change works.
  • (If the change is user-facing) I’ve added my changes to changelog_unreleased/*/XXXX.md file following changelog_unreleased/TEMPLATE.md.
  • I’ve read the contributing guidelines.

Try the playground for this PR

@sosukesuzuki sosukesuzuki marked this pull request as draft Nov 21, 2020
@sosukesuzuki sosukesuzuki changed the title Fix formatting for AssignmentExpression with ClassExpression [wip] Fix formatting for AssignmentExpression with ClassExpression Nov 21, 2020
src/language-js/print/class.js Outdated Show resolved Hide resolved
src/language-js/print/class.js Outdated Show resolved Hide resolved
@sosukesuzuki sosukesuzuki changed the title [wip] Fix formatting for AssignmentExpression with ClassExpression Fix formatting for AssignmentExpression with ClassExpression Nov 21, 2020
@sosukesuzuki sosukesuzuki marked this pull request as ready for review Nov 21, 2020
thorn0
thorn0 approved these changes Nov 21, 2020
fisker
fisker approved these changes Nov 21, 2020
@sosukesuzuki sosukesuzuki merged commit 3208b94 into prettier:master Nov 22, 2020
3 checks passed
@sosukesuzuki sosukesuzuki deleted the fix-9740 branch Nov 22, 2020
@sosukesuzuki sosukesuzuki mentioned this pull request Nov 22, 2020
1 task
sosukesuzuki added a commit that referenced this pull request Nov 25, 2020
* Fix formatting for asignment with superClass

* Add tests

* Changelog

* For only AssignmentExpression

* Remove unnecesary ifBreak
This was referenced Mar 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AssignmentExpression with ClassExpression are systematically wrapped regardless of length
3 participants