Fix exports #998

Merged
merged 4 commits into from Mar 15, 2017

Conversation

Projects
None yet
2 participants
@yamafaktory
Contributor

yamafaktory commented Mar 13, 2017

This should fix #995.

yamafaktory added some commits Mar 13, 2017

@yamafaktory

This comment has been minimized.

Show comment
Hide comment
@yamafaktory

yamafaktory Mar 13, 2017

Contributor

I don't get what Compared values have no visual difference. means after running the tests as this:

export { value1, value2 as value2_renamed, value3, value4 as value4_renamed, value5 } from "exports";

export a,{b} from "./baz";

export * as ns from "mod";

export * as foo,{bar} from "./baz";

is turned into:

export {
  value1,
  value2 as value2_renamed,
  value3,
  value4 as value4_renamed,
  value5
} from "exports";

export a, { b } from "./baz";

export * as ns from "mod";

export * as foo, { bar } from "./baz";

Which is fine...

Contributor

yamafaktory commented Mar 13, 2017

I don't get what Compared values have no visual difference. means after running the tests as this:

export { value1, value2 as value2_renamed, value3, value4 as value4_renamed, value5 } from "exports";

export a,{b} from "./baz";

export * as ns from "mod";

export * as foo,{bar} from "./baz";

is turned into:

export {
  value1,
  value2 as value2_renamed,
  value3,
  value4 as value4_renamed,
  value5
} from "exports";

export a, { b } from "./baz";

export * as ns from "mod";

export * as foo, { bar } from "./baz";

Which is fine...

@vjeux vjeux merged commit c82bb4e into prettier:master Mar 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@vjeux

This comment has been minimized.

Show comment
Hide comment
@vjeux

vjeux Mar 15, 2017

Collaborator

Thanks for fixing all the remaining edge cases!

Collaborator

vjeux commented Mar 15, 2017

Thanks for fixing all the remaining edge cases!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment