Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add A "Close Empty JSX Element" Option Like On VS Code's Prettier #202

Closed
RilDev opened this issue Aug 30, 2019 · 6 comments
Closed

Add A "Close Empty JSX Element" Option Like On VS Code's Prettier #202

RilDev opened this issue Aug 30, 2019 · 6 comments
Assignees

Comments

@RilDev
Copy link

RilDev commented Aug 30, 2019

Hi @mitermayer, as seen here it would be great to have a "Close Empty JSX Element" in Vim-Prettier so that <div></div> becomes <div /> when parsed.

Thank you for the kind support!

@RilDev RilDev changed the title Add A "Close Empty JSX Element" Like On VS Code's Prettier Add A "Close Empty JSX Element" Option Like On VS Code's Prettier Aug 30, 2019
@mitermayer mitermayer self-assigned this Aug 31, 2019
@mitermayer
Copy link
Member

Will work on it this weekend

@RilDev
Copy link
Author

RilDev commented Sep 9, 2019

Hi @mitermayer,

Have you got the time to develop this feature? Or is it planned for a later release date?

Cordially,
Cyril

@mitermayer
Copy link
Member

Sorry got stuck with family duties, hoping to do this in the next few days

@RilDev
Copy link
Author

RilDev commented Sep 12, 2019

I hope everything is alright with your family.

And thank you in advance for this feature!

@mitermayer mitermayer mentioned this issue Sep 12, 2019
13 tasks
@mitermayer
Copy link
Member

Hi @CyrilAntoni

Loking into prettier CLI i can't see any option for close-empty-jsx-elements, it does not seem to be part of upstream. I even try to dig up history to see what has happened and followed threads such as

Unfortunetly I won't be able to support this feature in here until it is supported on the prettier cli plugin itself.

If that functionality gets added to it, please then feel free to reopen this issue

@RilDev
Copy link
Author

RilDev commented Sep 14, 2019

Thank you for checking it up @mitermayer!

Alright then, I'll reopen the issue as soon as the cli support is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants