Fixes as follows: #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
larowlan
commented
Feb 9, 2017
larowlan
commented
- getTree used old API
- moveSubtreeToPosition assumed existing children in parent
larowlan
commented
Feb 9, 2017
src/Storage/DbalNestedSet.php
Outdated
| $depthDiff = $newNode->getDepth() - $node->getDepth(); | ||
| if (!$newNode) { | ||
| // No other children at this position, new depth = 1. | ||
| $depthDiff = 1 - $node->getDepth(); |
Member
Author
There was a problem hiding this comment.
Not sure about this, perhaps its better to get the previous node?
The issue is when you have parent at end of tree, there is no-one at the next position
Member
Author
There was a problem hiding this comment.
Maybe hold off merging while I try it with a second level end-node
Member
Author
|
self merging, let me know if any issues and will create follow ups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.