Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uploads pacakge #6

Merged
merged 1 commit into from
May 26, 2022
Merged

Update uploads pacakge #6

merged 1 commit into from
May 26, 2022

Conversation

aspirisen
Copy link
Contributor

No description provided.

@aspirisen aspirisen requested a review from e1himself May 25, 2022 15:30
@aspirisen aspirisen self-assigned this May 25, 2022
@linear
Copy link

linear bot commented May 25, 2022

DEV-5605 Coverage embed not working

Summary of the bug:

  • Cannot embed "coverage" type content in the campaign editor

Intercom conversation link:

Fullstory session link:

URL of page where bug occurred:

Licence link (from AdminUI):

Emulation link:

Browser version (customer's):

----------------

Can we reproduce the bug?

Yes

Reproduce steps:

image.png

  1. log coverage
  2. create campaign
  3. try to embed coverage using
  4. watch it fail

Expected result:

  • Coverage content is embedded

Actual result:

image.png

----------------

Engineer's Note:

Customer account >>> https://drive.google.com/uc?id=1DYsEnBR_pF8Bvs10zXHCWiKmoTXOkshK

My test account >> https://drive.google.com/uc?id=1r1nKjaqUE7hnnP2LtzPg-bcBmuV8s9v7

@@ -16,7 +16,7 @@
"sourceMap": true,
"strict": true,
"target": "es5",

"skipLibCheck": true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? 🤔 Doesn't it make the type-checking weaker?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was issues in library types in case when there was no extraneous dependencies in pnpm

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand. Can you please elaborate more on it?

@aspirisen aspirisen merged commit bde2e10 into master May 26, 2022
@aspirisen aspirisen deleted the fix/DEV-5605-coverage branch May 26, 2022 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants