Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken 2.4.x and 2.5.0 builds #602

Merged
merged 1 commit into from Oct 1, 2019
Merged

Fix broken 2.4.x and 2.5.0 builds #602

merged 1 commit into from Oct 1, 2019

Conversation

@sdalonzo
Copy link
Collaborator

sdalonzo commented Oct 1, 2019

Fixes an issue in DS v2.4.x and 2.5.0 where the cjs export from pcln-icons is incorrectly ingested by the esm rollup of core in core/Stepper/Step

Copy link
Contributor

abautist left a comment

LGTM, thanks

…icons is incorrectly injested by the esm rollup of core in core/Stepper/Step
@sdalonzo sdalonzo force-pushed the fix-bug-2_4_0 branch from 1740057 to 832f160 Oct 1, 2019
Copy link
Collaborator

James300 left a comment

Looks good to me

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 1, 2019

Codecov Report

Merging #602 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #602   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          63     63           
  Lines         664    664           
=====================================
  Hits          664    664
Impacted Files Coverage Δ
packages/core/src/Step.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d07e0...832f160. Read the comment docs.

@BeniCheni BeniCheni merged commit 3856ed0 into master Oct 1, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@BeniCheni BeniCheni deleted the fix-bug-2_4_0 branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.