CSV doesn't not invalidate associated label #2022

Closed
mustafacataltepe opened this Issue Jan 17, 2017 · 7 comments

Projects

None yet

3 participants

@mustafacataltepe
Contributor

1) Environment

  • PrimeFaces version: 6.0.13
  • Does it work on the newest PrimeFaces version? No
  • Application server + version: Tomcat 8.0.15
  • Affected browsers: Firefox / Chrome

2) Expected behavior

When in a form which has a selectOneRadio input and its defined with @NotNull at the backend, if CSV is set true label for the selectOneRadio should have ui-state-error class and turn to red.

3) Actual behavior

ui-state-error class is not added through CSV and label stays same. It is probably cause by validation javascript because when CSV set to false label gets the desired class.

@tandraschko
Member

Example please.

@mustafacataltepe
Contributor

Attached sample jetty app

sampleJettyApp.zip

@mustafacataltepe
Contributor

by the way sample app runs on 6.0 but behaviour is the same in 6.0.13

@tandraschko
Member

Not sure but it seems that label error style is not implemented, for no component:
showcase/ui/csv/bean.xhtml

@tandraschko tandraschko changed the title from CSV does not turn selectOneRadio label to red to CSV doesn't not invalidate associated label Jan 20, 2017
@mustafacataltepe
Contributor

added PR to address this issue it that's an ok fix can you merge it into next elite release please, thanks in advance.

@tandraschko tandraschko self-assigned this Jan 23, 2017
@tandraschko tandraschko added this to the 6.1 milestone Jan 23, 2017
@tandraschko
Member
tandraschko commented Jan 23, 2017 edited

@mertsincan Feel free to merge this into elite :)

@tandraschko tandraschko added enhancement and removed new feature labels Jan 23, 2017
@mertsincan
Member

Added to 6.0.15

@mertsincan mertsincan added the 6.0.15 label Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment