New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DatePicker: calendar-popup does not work with iOS 12.1.1 (Safari) and Android 8 (Chrome 71) #4417

Closed
christophs78 opened this Issue Jan 13, 2019 · 11 comments

Comments

Projects
None yet
5 participants
@christophs78
Copy link
Contributor

christophs78 commented Jan 13, 2019

1) Environment

  • PrimeFaces version: 6.3-SNAPSHOT, 7.0 RC1
  • Affected browsers:
    Safari (iOS 12.1.1); tested with iPad Pro 10.5"
    Chrome 71 (Android 8.0); tested with Huawei P10 lite

2) Expected behavior

https://www.primefaces.org/showcase/ui/input/datePicker.xhtml should work similar to https://www.primefaces.org/showcase/ui/input/calendar.xhtml

DatePicker does not open calendar-popup when used on Safari (iOS) or Chrome (Android).

3) Actual behavior

datepicker_ios_12_1_1
calendar_ios_12_1_1

https://www.primefaces.org/primeng/#/calendar work´s fine with iOS 12.1.1.
primeng_calendar_ios_12_1_1

As far as i understand Primefaces - DatePicker replicates PrimeNG Calendar.

4) Steps to reproduce

Open Showcase with iOS - Browser

@Rapster Rapster added the defect label Jan 13, 2019

@Rapster Rapster added this to the 6.3 milestone Jan 13, 2019

@markusg80

This comment has been minimized.

Copy link

markusg80 commented Jan 13, 2019

For me same issue

@mertsincan

This comment has been minimized.

Copy link
Member

mertsincan commented Jan 14, 2019

Hi @christophs78 and @markusg80,

Could you please try this fix?

@christophs78

This comment has been minimized.

Copy link
Contributor Author

christophs78 commented Jan 14, 2019

@mertsincan - the official showcase had not been updated yet?
I will recheck after it is updated. (I have no environment where i am able to test the current github-Snapshot easily on my iPad.)

@markusg80

This comment has been minimized.

Copy link

markusg80 commented Jan 14, 2019

For me same situation

@christophs78 christophs78 changed the title DatePicker: calendar-popup does not work with iOS 12.1.1 (Safari) DatePicker: calendar-popup does not work with iOS 12.1.1 (Safari) and Android 8 (Chrome 71) Jan 16, 2019

@christophs78

This comment has been minimized.

Copy link
Contributor Author

christophs78 commented Jan 16, 2019

The issue still persists with PF 7.0 RC1. (official showcase)
I´m able to reproduce this issue with iOS 12.1.1 (Safari) and on Android (8.0) with Chrome 71 (Huawei P10 lite).
screenshot_20190116-174853

@christophs78

This comment has been minimized.

Copy link
Contributor Author

christophs78 commented Jan 17, 2019

@mertsincan - I invested some time to remote-debug chrome 71 on my android-phone.
Console show´s following error when i put the focus into the "Popup" - input-field:
grafik
Can we please reopen this issue?

@tandraschko tandraschko reopened this Jan 17, 2019

@mertsincan mertsincan self-assigned this Jan 18, 2019

@mertsincan mertsincan added the 6.2.15 label Jan 18, 2019

@mertsincan

This comment has been minimized.

Copy link
Member

mertsincan commented Jan 18, 2019

Good catch, @christophs78 ;) Fixed now.

@mertsincan

This comment has been minimized.

Copy link
Member

mertsincan commented Jan 18, 2019

@christophs78

This comment has been minimized.

Copy link
Contributor Author

christophs78 commented Jan 18, 2019

Well done! Datepicker now works on iOS and Android/Chrome.

@mertsincan

This comment has been minimized.

Copy link
Member

mertsincan commented Jan 18, 2019

Thanks to you ;)

@markusg80

This comment has been minimized.

Copy link

markusg80 commented Jan 18, 2019

Now it looks nice! Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment