New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatable: Rowgrouping issue if value is null #4455

Closed
KarlKnapp opened this Issue Jan 21, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@KarlKnapp
Copy link

KarlKnapp commented Jan 21, 2019

If the group value is empty a new group is created for each row.

1) Environment

  • PrimeFaces version: 6.2

2) Expected behavior

grouprowfixed

3) Actual behavior

grouprowbroken

4) Steps to reproduce

5) Sample XHTML

<p:headerRow>
       <p:column colspan="8">
              <h:outputText value="#{item.THIS_VALUE_IS_NULL}" />
      </p:column>
 </p:headerRow>
@mertsincan

This comment has been minimized.

Copy link
Member

mertsincan commented Jan 23, 2019

Thanks a lot for the PR ;)

mertsincan added a commit that referenced this issue Jan 23, 2019

Merge pull request #4459 from KarlKnapp/master
Fixes #4455 Datatable: Rowgrouping issue if value is null

@mertsincan mertsincan added this to the 7.0 milestone Jan 23, 2019

tandraschko added a commit that referenced this issue Jan 23, 2019

@tandraschko

This comment has been minimized.

Copy link
Member

tandraschko commented Jan 23, 2019

@KarlKnapp refactored with Objects.equals - Could you give it a try?

@KarlKnapp

This comment has been minimized.

Copy link
Author

KarlKnapp commented Jan 25, 2019

Seems to work, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment