Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LinkButton: 'target' and 'title' attributtes not rendered #4662

Closed
jasonex7 opened this issue Mar 20, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@jasonex7
Copy link
Contributor

commented Mar 20, 2019

1) Environment

  • PrimeFaces version: 7.0
  • Does it work on the newest released PrimeFaces version? No
  • Does it work on the newest sources in GitHub? No
  • Application server + version: Jetty 9.4 from https://github.com/primefaces/primefaces-test
  • Affected browsers: ALL

2) Expected behavior

'Target' and 'title' attributes should be rendered because there are in primefaces-p.taglib.xml.

<p:linkButton outcome="test2" target="_BLANK" title="Test Title" value="Link Button" />

Should be render as

<span id="j_idt6" class="ui-linkbutton ui-button ui-widget ui-state-default ui-corner-all ui-button-text-only" role="button" title="Test Title">
     <a href="/primefaces-test/test2.xhtml" target="_BLANK"><span class="ui-button-text ui-c">Link Button</span></a>
</span>

3) Actual behavior

Doesn't render 'target' nor 'title' attributes.

Got render as

<span id="j_idt6" class="ui-linkbutton ui-button ui-widget ui-state-default ui-corner-all ui-button-text-only" role="button">
     <a href="/primefaces-test/test2.xhtml"><span class="ui-button-text ui-c">Link Button</span></a>
</span>

4) Sample XHTML

<p:linkButton outcome="test2" target="_BLANK" title="Test Title" value="Link Button" />

jasonex7 added a commit to jasonex7/primefaces that referenced this issue Mar 20, 2019

tandraschko added a commit that referenced this issue Mar 24, 2019

Merge pull request #4663 from jasonex7/linkbutton-attributes
 Fixes #4662 - LinkButton: 'target' and 'title' attributtes not rendered

@tandraschko tandraschko added this to the 7.1 milestone Mar 24, 2019

@erickdeoliveiraleal

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

@mertsincan can you merge it in elite release?

@mertsincan

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

Of course! Thanks a lot ;)

@mertsincan mertsincan added the 7.0.4 label Jun 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.