Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button: Missplaced active frame with Firefox #4697

Closed
OBreidenbach opened this issue Mar 27, 2019 · 4 comments

Comments

Projects
None yet
5 participants
@OBreidenbach
Copy link
Contributor

commented Mar 27, 2019

1) Environment

2) Expected behavior

Frame around clicked buttons which only have a icon and no text is close to the button.

3) Actual behavior

On Firefox the left frame boarder is moved somewhere to the left

4) Steps to reproduce

Use Firefox to go to: https://www.primefaces.org/showcase/ui/button/commandButton.xhtml
and click the button with only the save icon.

buttonFrameFirefox2

@melloware

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

Can you tell if this is Theme related or actually button related?

@tandraschko tandraschko added the defect label Mar 27, 2019

@jepsar

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

It's caused by this property:

Is someone already working on a PR?

@mertsincan

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

Hi,

Could you please try the following css for this issue?

<style type="text/css">
body .ui-button.ui-button-icon-only {
  overflow: hidden; 
}
body .ui-button.ui-button-icon-only .ui-button-text {
    text-indent: 0;
    white-space: nowrap;
    visibility: hidden; 
}
</style>
@jepsar

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

@mertsincan looks like less of a hack to me. First test with Firefox is promising. I'll test with Chrome and Safari in a few hours.

tandraschko added a commit that referenced this issue Mar 28, 2019

Merge pull request #4698 from jepsar/patch-1
Fix #4697 Negative CSS text indent causes outline wrapping text in Firefox

@tandraschko tandraschko added this to the 7.1 milestone Mar 28, 2019

@mertsincan mertsincan self-assigned this May 7, 2019

mertsincan added a commit that referenced this issue May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.